-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate most everything #1798
Annotate most everything #1798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome Matt, great work. I think I only found 1 mistake where there was some vestigial type annotation in a docstring, and all my other comments are pretty much just ways to get rid of type: ignore comments that you can adopt if you like. Sorry this took so long to review and thanks so much for doing it!
assume_missing_is_default | ||
??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This argument isn't used in the function body, so I guess it's ignored and just here to avoid a breaking change? If so we should document that it doesn't do anything or remove it.
@j-wags Any idea what this parameter is supposed to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Josh A. Mitchell <[email protected]>
Co-authored-by: Josh A. Mitchell <[email protected]>
Thanks for the review @Yoshanuikabundi - there are three loose ends I'm leaving unresolved, but I think everything else here is working! |
Happy holidays @Yoshanuikabundi - I think I'll break this up into a few smaller changes but this is the gist of what is encompassed
check_untyped_defs = True