Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev CI #120

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Fix dev CI #120

merged 11 commits into from
Jul 16, 2024

Conversation

lilyminium
Copy link
Collaborator

@lilyminium lilyminium commented Jul 15, 2024 •
edited
Loading

This PR fixes some of dev CI (indents the exclude job, pulls in importlib_resources) but not all of it (i.e. #121)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.82%. Comparing base (84302e5) to head (ca2ba2e).

Additional details and impacted files

@lilyminium lilyminium merged commit 3d251ed into main Jul 16, 2024
51 of 62 checks passed
@lilyminium lilyminium deleted the fix-dev-ci branch July 16, 2024 07:10
@lilyminium lilyminium mentioned this pull request Oct 14, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilyminium @codecov-commenter