Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5428 - page dedicated to prices #5730

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now all the links related to prices are on a single dedicated page, from the account page.

Screenshots

account page prices home page
Screenshot_1729765784 Screenshot_1729766371

Fixes bug(s)

Files

New file:

  • prices_home_page.dart: Home page of Prices

Impacted file:

  • user_preferences_account.dart: replaced the whole prices items with a single item linking to new page PricesHomePage

New file:
* `prices_home_page.dart`: Home page of Prices

Impacted file:
* `user_preferences_account.dart`: replaced the whole prices items with a single item linking to new page `PricesHomePage`
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 19.54023% with 70 lines in your changes missing coverage. Please review.

Project coverage is 7.00%. Comparing base (4d9c7fc) to head (92ca3b3).
Report is 382 commits behind head on develop.

Files with missing lines Patch % Lines
...lib/pages/preferences/user_preferences_prices.dart 5.88% 64 Missing ⚠️
...b/pages/preferences/user_preferences_donation.dart 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5730      +/-   ##
==========================================
- Coverage     9.54%   7.00%   -2.55%     
==========================================
  Files          325     406      +81     
  Lines        16411   21648    +5237     
==========================================
- Hits          1567    1516      -51     
- Misses       14844   20132    +5288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

@monsieurtanuki Can you move it up a level ?
Can you also do the same for the donation item in Contribute (after Connect with us)

@monsieurtanuki
Copy link
Contributor Author

Can you move it up a level ?

You mean, a "prices" button directly from the main "Mes préférences" page and not from "My account" page?

Can you also do the same for the donation item in Contribute (after Connect with us)

That would only mean moving the single "donation" button to the main page, right?

@teolemon
Copy link
Member

yes & yes, that would be it

New files:
* `user_preferences_donation.dart`: Display of "Donation" for the preferences page.
* `user_preferences_prices.dart`: Display of "Prices" for the preferences page.

Deleted file:
* `prices_home_page.dart`

Impacted files:
* `app_en.arb`: added a short label for "donation"
* `user_preferences_account.dart`: removed link to `PricesHomePage`
* `user_preferences_contribute.dart`: removed the "donation" item
* `user_preferences_page.dart`: added "donation" and "prices" as preferences
@monsieurtanuki
Copy link
Contributor Author

yes & yes, that would be it

@teolemon Done

home prices
Screenshot_1729795445 Screenshot_1729795451

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teolemon teolemon merged commit 4b8489d into openfoodfacts:develop Oct 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Group the price related contribution items in a sub-menu
3 participants