Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS icons with an alpha channel #5722

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Oct 21, 2024

A fix for #5720
Basically, all icons now have a background color instead of a transparent one.

@g123k g123k added 🍎 iOS iOS specific issues or PRs icon labels Oct 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.95%. Comparing base (4d9c7fc) to head (c8bd04a).
Report is 379 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5722      +/-   ##
==========================================
- Coverage     9.54%   6.95%   -2.60%     
==========================================
  Files          325     404      +79     
  Lines        16411   21607    +5196     
==========================================
- Hits          1567    1502      -65     
- Misses       14844   20105    +5261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon
Copy link
Member

thank you very very much @g123k

@teolemon teolemon merged commit cfa5dae into openfoodfacts:develop Oct 21, 2024
6 checks passed
@g123k g123k deleted the ios_icons_alpha branch November 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon 🍎 iOS iOS specific issues or PRs
Development

Successfully merging this pull request may close these issues.

roll back the content of AppIcon.appiconset The flutter icons removal have broken the iOS build
4 participants