Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deeplinking for the forgot password page #5362

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

feat: Deeplinking for the forgot password page #5362

wants to merge 10 commits into from

Conversation

jnnabugwu
Copy link
Contributor

What

Added deep linking for the forgot password page.

can be tested at https://world.openfoodfacts.org/forgot-password/

Screenshot

Screen.Recording.2024-06-12.at.4.41.26.PM.mov

Fixes bug(s)

  • Fixes:

Part of

@jnnabugwu jnnabugwu requested a review from a team as a code owner June 12, 2024 20:52
@g123k g123k changed the title Deeplinking forgot password feat: Deeplinking forgot password Jun 13, 2024
@g123k
Copy link
Collaborator

g123k commented Jun 13, 2024 •
edited by M123-dev
Loading

You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362

Running dart format . should fix this

@jnnabugwu
Copy link
Contributor Author

You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362

Running dart format . should fix this

Sorry, I missed this. I will fix this

@g123k
Copy link
Collaborator

g123k commented Jul 2, 2024

You have a formatting issue on your code: https://github.com/openfoodfacts/smooth-app/actions/runs/9489564735/job/26151127165?pr=5362
Running dart format . should fix this

Sorry, I missed this. I will fix this

It seems your commit partially fixes the issue.
Just run the command, it should be fine.

Screenshot 2024-07-02 at 12 29 44

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 7.00%. Comparing base (4d9c7fc) to head (a603218).
Report is 270 commits behind head on develop.

Files Patch % Lines
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           develop   #5362      +/-   ##
==========================================
- Coverage     9.54%   7.00%   -2.54%     
==========================================
  Files          325     397      +72     
  Lines        16411   21043    +4632     
==========================================
- Hits          1567    1475      -92     
- Misses       14844   19568    +4724

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k
Copy link
Collaborator

g123k commented Jul 4, 2024

Thanks for the fix.
What happens when you click on the back button on top? (left arrow)

@jnnabugwu
Copy link
Contributor Author

Thanks for the fix. What happens when you click on the back button on top? (left arrow)

Let me check

@jnnabugwu
Copy link
Contributor Author

[

Screen.Recording.2024-07-06.at.1.39.36.PM.mov

](url)

It goes back to the home page

@M123-dev
Copy link
Member

@g123k

g123k
g123k requested changes Jul 29, 2024
View reviewed changes
packages/smooth_app/lib/pages/navigator/app_navigator.dart Outdated
@@ -282,6 +287,8 @@ class _SmoothGoRouter {
}
} else if (path == _ExternalRoutes.MOBILE_APP_DOWNLOAD) {
return AppRoutes.HOME;
} else if (path == _ExternalRoutes.FORGOT_PASSWORD) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this statement before or after SIGNUP?
It will allow the regrouping of user management routes.
Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay will do

@teolemon teolemon added the ✨ enhancement New feature or request label Aug 1, 2024
@teolemon teolemon changed the title feat: Deeplinking forgot password feat: Deeplinking for the forgot password page Aug 1, 2024
@teolemon teolemon added the 🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps label Aug 1, 2024
@M123-dev
Copy link
Member

M123-dev commented Oct 7, 2024

Heyy, there are some conflicts, but they seem to be just a few lines.
Is planned to continue this PR

@jnnabugwu
Copy link
Contributor Author

Yeah ill have this cleaned up this week really by tomorrow

@github-actions github-actions bot added the router label Nov 6, 2024
@jnnabugwu jnnabugwu requested a review from g123k November 6, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g123k g123k Awaiting requested review from g123k

Requested changes must be addressed to merge this pull request.

Assignees

@jnnabugwu jnnabugwu

Labels
🔗 Deeplinking Ensure people browsing Open Food Facts on the mobile web have a bridge to the mobile apps ✨ enhancement New feature or request 🔐 Password reset router
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 🏗️ In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jnnabugwu @g123k @codecov-commenter @M123-dev @teolemon