Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NutriScore guide with working Share button + Analytics events #5303

Merged
merged 1 commit into from
May 28, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented May 28, 2024

Hi everyone,

Here are my changes:

  • The share button is now working
  • Analytics events when the screen is opened and the share button is clicked
  • The screen opens in fullscreen from FAQ

Note: translations seem to take some time to deploy

@g123k g123k requested a review from a team as a code owner May 28, 2024 15:53
@g123k g123k linked an issue May 28, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 7.73%. Comparing base (4d9c7fc) to head (1d74737).
Report is 146 commits behind head on develop.

Files Patch % Lines
...th_app/lib/pages/guides/helpers/guides_footer.dart 0.00% 10 Missing ⚠️
...h_app/lib/pages/guides/helpers/guides_content.dart 0.00% 8 Missing ⚠️
...pp/lib/pages/guides/guide/guide_nutriscore_v2.dart 0.00% 4 Missing ⚠️
packages/smooth_app/lib/main.dart 0.00% 1 Missing ⚠️
...pp/lib/pages/preferences/user_preferences_faq.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5303      +/-   ##
==========================================
- Coverage     9.54%   7.73%   -1.82%     
==========================================
  Files          325     366      +41     
  Lines        16411   18499    +2088     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17069    +2225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit 6274c73 into openfoodfacts:develop May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Integrate a guide to explain the new Nutri-Score
3 participants