feat: 5200 - currency selector #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `currency_selector.dart`: A selector for selecting user's currency. * `user_preferences_currency_selector.dart`: Currency selector within user preferences. Impacted files: * `app_en.arb`: added 2 labels for the currency selector * `country_selector.dart`: fixed discrepancies between selector display * `user_preferences.dart`: new "user currency code" getter/setter * `user_preferences_settings.dart`: added currency selector * `welcome_page.dart`: fixed discrepancies between selector display
github-actions
bot
added
the
🤗 Onboarding
teolemon
approved these changes
May 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5236 +/- ##
==========================================
- Coverage 9.54% 8.63% -0.92%
==========================================
Files 325 329 +4
Lines 16411 16684 +273
==========================================
- Hits 1567 1441 -126
- Misses 14844 15243 +399 ☔ View full report in Codecov by Sentry. |
|
Thank you @teolemon for your review!
Definitely. Could be done partly in the onboarding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Fixes bug(s)
Files
New files:
currency_selector.dart: A selector for selecting user's currency.user_preferences_currency_selector.dart: Currency selector within user preferences.Impacted files:
app_en.arb: added 2 labels for the currency selectorcountry_selector.dart: fixed discrepancies between selector displayuser_preferences.dart: new "user currency code" getter/setteruser_preferences_settings.dart: added currency selectorwelcome_page.dart: fixed discrepancies between selector display