Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bring back the loading animation #5114

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Mar 11, 2024

Hi everyone,

The "Loading" animation was removed from the Rive file, after some changes with the POC.
So this is now fixed.

g123k and others added 5 commits February 1, 2024 14:48
[pull] develop from openfoodfacts:develop
[pull] develop from openfoodfacts:develop
[pull] develop from openfoodfacts:develop
[pull] develop from openfoodfacts:develop
@g123k g123k requested a review from a team as a code owner March 11, 2024 08:04
@g123k g123k linked an issue Mar 11, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.53%. Comparing base (4d9c7fc) to head (f56f56c).
Report is 47 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5114      +/-   ##
==========================================
- Coverage     9.54%   9.53%   -0.02%     
==========================================
  Files          325     327       +2     
  Lines        16411   16529     +118     
==========================================
+ Hits          1567    1576       +9     
- Misses       14844   14953     +109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @g123k!

@teolemon teolemon merged commit 122123b into openfoodfacts:develop Mar 12, 2024
6 checks passed
@teolemon
Copy link
Member

thank you both :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatException: FormatException: Unable to load artboard
4 participants