Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migration to Flutter 3.16 #4917

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Dec 21, 2023

Hi everyone,

It's now safe to migrate to Flutter 3.16.

The only change is related to WillPopScope, which is now deprecated.
There are lots of complaints on the official tracker, but I've created a WillPopScope2 with the same kind of feature.

BUT there is a change: we now need to pass 2 values:

  • a boolean that says if we want to close or not the page
  • a value that we want to pass, to the pop() method - for now, it's always null, but the API is ready

@g123k g123k requested a review from a team as a code owner December 21, 2023 15:43
@g123k g123k linked an issue Dec 21, 2023 that may be closed by this pull request
@github-actions github-actions bot added 📚 Documentation Improvements or additions to documentation 🥫 Product page Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🧪 Tests dependencies ✏️ Editing - Nutrition input ✏️ Editing - Basic info input User lists ✏️ Editing - 📦 Packaging input labels Dec 21, 2023
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g123k ! 😄

@teolemon
Copy link
Member

Run dart format --set-exit-if-changed .
Formatted packages/smooth_app/lib/pages/product/add_basic_details_page.dart
Formatted packages/smooth_app/lib/pages/product/portion_calculator.dart
Formatted packages/smooth_app/lib/widgets/will_pop_scope.dart
Formatted 394 files (3 changed) in 1.65 seconds.
Error: Process completed with exit code 1.

@g123k
Copy link
Collaborator Author

g123k commented Jan 4, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (e0b3111) 9.66% compared to head (cf5c0fe) 9.66%.

Files Patch % Lines
...ackages/smooth_app/lib/widgets/will_pop_scope.dart 0.00% 9 Missing ⚠️
packages/smooth_app/lib/pages/crop_page.dart 0.00% 2 Missing ⚠️
...ib/pages/onboarding/onboarding_flow_navigator.dart 0.00% 2 Missing ⚠️
..._app/lib/pages/product/add_basic_details_page.dart 0.00% 2 Missing ⚠️
...th_app/lib/pages/product/add_new_product_page.dart 0.00% 2 Missing ⚠️
..._app/lib/pages/product/add_other_details_page.dart 0.00% 2 Missing ⚠️
...pp/lib/pages/product/common/product_list_page.dart 0.00% 2 Missing ⚠️
...oth_app/lib/pages/product/edit_new_packagings.dart 0.00% 2 Missing ⚠️
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% 2 Missing ⚠️
...mooth_app/lib/pages/product/simple_input_page.dart 0.00% 2 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4917      +/-   ##
==========================================
- Coverage     9.66%   9.66%   -0.01%     
==========================================
  Files          322     323       +1     
  Lines        16177   16187      +10     
==========================================
  Hits          1564    1564              
- Misses       14613   14623      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g123k
Copy link
Collaborator Author

g123k commented Jan 8, 2024

The build is now OK 👌

@teolemon teolemon merged commit bccdf1c into openfoodfacts:develop Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 📚 Documentation Improvements or additions to documentation ✏️ Editing - Basic info input ✏️ Editing - Nutrition input ✏️ Editing - 📦 Packaging input 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🧪 Tests User lists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new Flutter version is available: 3.16.0
5 participants