Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Formatting issue + dependencies upgraded #4802

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 16, 2023

Hi everyone,

I have done a flutter/dart pub upgrade to ensure the pubspec.lock is now the same for everyone.
Furthermore, I have fixed the issue mentionned in #4799

@g123k g123k requested a review from a team as a code owner November 16, 2023 07:21
@github-actions github-actions bot added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. product page labels Nov 16, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Comparison is base (3758744) 9.86% compared to head (948f9c2) 9.83%.
Report is 3 commits behind head on develop.

Files Patch % Lines
...th_app/lib/pages/product/add_new_product_page.dart 0.00% 114 Missing ⚠️
..._app/lib/pages/product/add_new_product_helper.dart 0.00% 3 Missing ⚠️
...s/product_cards/smooth_product_card_not_found.dart 0.00% 2 Missing ⚠️
.../smooth_app/lib/helpers/image_field_extension.dart 0.00% 2 Missing ⚠️
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #4802      +/-   ##
==========================================
- Coverage     9.86%   9.83%   -0.03%     
==========================================
  Files          312     312              
  Lines        15872   15908      +36     
==========================================
  Hits          1565    1565              
- Misses       14307   14343      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@teolemon teolemon merged commit fc5daa6 into openfoodfacts:develop Nov 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants