Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tiny UI tweaks for the product edition #4456

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 5, 2023

Hi everyone,

I think you know me now, small details aren't that small and I've "pixel-perfected" some screens:

  • Photo cropper/viewer: the Edit button is centered on the left
Screenshot 2023-08-05 at 20 45 04
  • Photo cropper/viewer: the InkWell takes the full height/width within the border
Screenshot 2023-08-05 at 22 26 02
  • Bottom bar buttons (the change will also affect Dialogs): the "negative" action has the same height as the positive one
Screenshot 2023-08-05 at 22 24 32
  • Cards to edit values: everything is perfectly aligned (on both sides) + I've removed the Divider (but if you don't like, I can revert this part)
Screenshot 2023-08-05 at 22 28 19

This is brought to you by the only user that will notice the changes 🤪

@g123k g123k requested a review from a team as a code owner August 5, 2023 20:45
@g123k g123k self-assigned this Aug 5, 2023
@g123k g123k linked an issue Aug 5, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #4456 (f180f85) into develop (6fd6aa8) will increase coverage by 0.03%.
Report is 6 commits behind head on develop.
The diff coverage is 58.82%.

@@             Coverage Diff             @@
##           develop    #4456      +/-   ##
===========================================
+ Coverage    10.26%   10.29%   +0.03%     
===========================================
  Files          296      296              
  Lines        15223    15233      +10     
===========================================
+ Hits          1562     1568       +6     
- Misses       13661    13665       +4     
Files Changed Coverage Δ
...mooth_app/lib/pages/product/edit_image_button.dart 0.00% <0.00%> (ø)
...ooth_app/lib/pages/product/explanation_widget.dart 0.00% <ø> (ø)
...th_app/lib/pages/product/product_image_viewer.dart 0.00% <0.00%> (ø)
...mooth_app/lib/pages/product/simple_input_page.dart 0.00% <0.00%> (ø)
...app/lib/pages/product/simple_input_text_field.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% <ø> (ø)
packages/smooth_app/lib/themes/theme_provider.dart 40.90% <33.33%> (-1.20%) ⬇️
.../lib/generic_lib/buttons/smooth_simple_button.dart 86.36% <66.66%> (-7.39%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 66.66% <93.75%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but I really can't spot the difference 🫠

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

You can test this PR on: Android

@teolemon teolemon merged commit a4998cd into openfoodfacts:develop Aug 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product edition: UI tweaks needed
3 participants