fix: 4424 - longer label for "empty the list" + refactoring #4447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `all_products_list_page.dart`: refactored around `ProductListPopupItem` * `app_en.arb`: new label for a more explicit "empty the list" * `app_fr.arb`: new label for a more explicit "empty the list" * `product_list_popup_items.dart`: moved there `ProductListPopupMenuEntry`; added 2 methods to `ProductListPopupItem`; added 1 implementation of `ProductListPopupItem`
Codecov Report
@@ Coverage Diff @@
## develop #4447 +/- ##
========================================
Coverage 10.17% 10.17%
========================================
Files 295 295
Lines 15087 15081 -6
========================================
Hits 1535 1535
+ Misses 13552 13546 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You can test this PR on: Android |
g123k
reviewed
Aug 4, 2023
| ]; | ||
| final List<PopupMenuEntry<ProductListPopupMenuEntry>> |
There was a problem hiding this comment.
Why not use the map operator here instead?
There was a problem hiding this comment.
I tried to find something relevant but couldn't find anything.
I'm not at ease with those map/list methods anyway.
My code can be read by anyone, uses OOP and has no copy/paste, which is good enough for me.
3 tasks
|
Thank you @teolemon for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Impacted files
all_products_list_page.dart: refactored aroundProductListPopupItemapp_en.arb: new label for a more explicit "empty the list"app_fr.arb: new label for a more explicit "empty the list"product_list_popup_items.dart: moved thereProductListPopupMenuEntry; added 2 methods toProductListPopupItem; added 1 implementation ofProductListPopupItem