Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 4041 - removed redundant and misplaced "user lists" #4303

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • There was an access to user lists from the user preferences.
  • Now that we have a fast access to all lists, including user lists, we can remove that previous access in order to avoid redundancy and confusion.

Screenshot

There used to be a "My lists" entry there, now redundant.
Screenshot_2023-07-14-09-11-59

Part of

Files

Deleted files:

  • all_user_product_list_page.dart
  • user_preferences_user_lists.dart

Impacted file:

  • user_preferences_page.dart: removed the access to "user lists", who was misplaced here and is now redundant with the latest "lists" tab

Deleted files:
* `all_user_product_list_page.dart`
* `user_preferences_user_lists.dart`

Impacted file:
* `user_preferences_page.dart`: removed the access to "user lists", who was misplaced here and is now redundant with the latest "lists" tab
@codecov-commenter
Copy link

Codecov Report

Merging #4303 (9667799) into develop (296a0d2) will decrease coverage by 0.03%.
The diff coverage is 1.69%.

@@             Coverage Diff             @@
##           develop    #4303      +/-   ##
===========================================
- Coverage    10.82%   10.80%   -0.03%     
===========================================
  Files          288      287       -1     
  Lines        14264    14202      -62     
===========================================
- Hits          1544     1534      -10     
+ Misses       12720    12668      -52     
Impacted Files Coverage Δ
...ages/smooth_app/lib/database/dao_product_list.dart 4.61% <0.00%> (-0.23%) ⬇️
...p/lib/pages/preferences/user_preferences_page.dart 93.58% <ø> (-0.32%) ⬇️
...pp/lib/pages/product/common/product_list_page.dart 0.00% <0.00%> (ø)
...pages/product/common/product_list_popup_items.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (ø)
...app/lib/pages/product_list_user_dialog_helper.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/all_product_list_page.dart 2.77% <2.77%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK for me.
Have you just checked that translations from the old screen are removed?

@monsieurtanuki monsieurtanuki merged commit 1cd22a6 into openfoodfacts:develop Jul 14, 2023
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Have you just checked that translations from the old screen are removed?

No I haven't, it's supposedly done in #3856 (and I have never understood how the conflicts are dealt with between flutter and crowdin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants