fix: 4301 - "other lists" button always visible

[monsieurtanuki]

What

• In the "product list" page, there is one "more ..." button that is not always visible (e.g. not much you can do with an empty list)
• But recently we added an "other lists" button, that must always be visible.
• The bug was that we used the same condition to display both buttons, making the "other lists" button invisible when the list was empty.
• The fix was just about moving the test.

Screenshot

Part of

• New list picker scan session broken, when empty #4301 Defragment the history/list experience #4041

Impacted file

• product_list_page.dart: the "other lists" button is now always visible

[codecov-commenter]

Codecov Report

Merging #4302 (750ea82) into develop (296a0d2) will decrease coverage by 0.01%.
The diff coverage is 1.26%.

@@             Coverage Diff             @@
##           develop    #4302      +/-   ##
===========================================
- Coverage    10.82%   10.82%   -0.01%     
===========================================
  Files          288      289       +1     
  Lines        14264    14274      +10     
===========================================
+ Hits          1544     1545       +1     
- Misses       12720    12729       +9     

Impacted Files	Coverage Δ
...ages/smooth_app/lib/database/dao_product_list.dart	4.61% <0.00%> (-0.23%)	⬇️
...ooth_app/lib/pages/all_user_product_list_page.dart	1.85% <0.00%> (+0.26%)	⬆️
...pp/lib/pages/product/common/product_list_page.dart	0.00% <0.00%> (ø)
...pages/product/common/product_list_popup_items.dart	0.00% <0.00%> (ø)
...smooth_app/lib/pages/product/new_product_page.dart	0.00% <0.00%> (ø)
...app/lib/pages/product_list_user_dialog_helper.dart	0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/all_product_list_page.dart	2.77% <2.77%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[M123-dev]

That was quick, thanks @monsieurtanuki

[monsieurtanuki]

Thank you @M123-dev for your quick review!