Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Finalize new pipeline #2824

Merged
merged 1 commit into from
Aug 21, 2022
Merged

ci: Finalize new pipeline #2824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
📦 Existing
App Store Release(TestFlight):
Process: deliver the IOS version onto TestFlight [.github/release.yml](https://github.com/openfoodfacts/smooth-app/blob/develop/.github/release.yml)
Event: Push on [release/*]


Crowdin Action：
Process: Dump sources and download translations from Crowdin [.github/crowdin.yml](https://github.com/openfoodfacts/smooth-app/blob/develop/.github/crowdin.yml)
Expand All @@ -14,16 +10,14 @@ Labeler:
Event: Creation PR


Google Play Release:
Process: deliver Android version onto Google Play [.github/release.yml](https://github.com/openfoodfacts/smooth-app/blob/develop/.github/release.yml)
Event: Push on [release/*]


Github Pages Deploy Action:
Process: Deploy auto-generated APIs document in GitHub Pages https://openfoodfacts.github.io/smooth-app/
Event: Push onto [develop]


Release please:
Process: Update version.txt and CHANGELOG.md by setting release-type=simple
Event: Push onto [develop]
Release:
The release process is triggered by release please (by merging a generated "chore(develop): release x.x.x" pull request).
This triggers the release to the Play- and App-Store using [Fastlane](https://fastlane.tools/).
[Release please](https://github.com/openfoodfacts/smooth-app/blob/develop/.github/release-please.yml)
[Android release](https://github.com/openfoodfacts/smooth-app/blob/develop/.github/android-release-to-org-openfoodfacts-scanner.yml)
[iOS please](https://github.com/openfoodfacts/smooth-app/blob/develop/.github/ios-release-to-org-openfoodfacts-scanner.yml)
21 changes: 10 additions & 11 deletions .github/workflows/android-release-to-org-openfoodfacts-scanner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,13 @@ jobs:
SIGN_KEY_ALIAS: ${{ secrets.SIGN_KEY_ALIAS }}
SIGN_KEY_PASSWORD: ${{ secrets.SIGN_KEY_PASSWORD }}

# - name: Release AAB
# uses: maierj/[email protected]
# with:
# lane: closed_beta
# subdirectory: packages/smooth_app/android
# env:
# SIGN_STORE_PATH: ./../fastlane/envfiles/keystore.jks
# SIGN_STORE_PASSWORD: ${{ secrets.SIGN_STORE_PASSWORD }}
# SIGN_KEY_ALIAS: ${{ secrets.SIGN_KEY_ALIAS }}
# SIGN_KEY_PASSWORD: ${{ secrets.SIGN_KEY_PASSWORD }}

- name: Release AAB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had it been disabled by the previous work you had merged ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I've disabled it so that for example android works but not iOS I don't submit lots of dublicate builds

uses: maierj/[email protected]
with:
lane: closed_beta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is fastlane actually sending to closed_beta ? or internal ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal

subdirectory: packages/smooth_app/android
env:
SIGN_STORE_PATH: ./../fastlane/envfiles/keystore.jks
SIGN_STORE_PASSWORD: ${{ secrets.SIGN_STORE_PASSWORD }}
SIGN_KEY_ALIAS: ${{ secrets.SIGN_KEY_ALIAS }}
SIGN_KEY_PASSWORD: ${{ secrets.SIGN_KEY_PASSWORD }}
32 changes: 16 additions & 16 deletions .github/workflows/ios-release-to-org-openfoodfacts-scanner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,20 @@ jobs:
- name: cat Podfile
run: cd ./packages/smooth_app/ios && cat Podfile

# - name: Release ipa
# run: cd ./packages/smooth_app/ios && bundle exec fastlane beta
# env:
# GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
# FASTLANE_USER: ${{ secrets.FASTLANE_USER }}
# FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: ${{ secrets.FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD }}
# MATCH_GIT_BASIC_AUTHORIZATION: ${{ secrets.MATCH_GIT_BASIC_AUTHORIZATION }}
# MATCH_GIT_URL: ${{ secrets.MATCH_GIT_URL }}
# MATCH_KEYCHAIN_PASSWORD: ${{ secrets.MATCH_KEYCHAIN_PASSWORD }}
# MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
# PILOT_APPLE_ID: ${{ secrets.PILOT_APPLE_ID }}
# SPACESHIP_CONNECT_API_ISSUER_ID: ${{ secrets.SPACESHIP_CONNECT_API_ISSUER_ID }}
# SPACESHIP_CONNECT_API_KEY_ID: ${{ secrets.SPACESHIP_CONNECT_API_KEY_ID }}
# SPACESHIP_CONNECT_API_KEY_FILEPATH: ./fastlane/envfiles/AuthKey_KDAUTTM76R.p8
# CI_RELEASE: true
- name: Release ipa
run: cd ./packages/smooth_app/ios && bundle exec fastlane beta
env:
GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
FASTLANE_USER: ${{ secrets.FASTLANE_USER }}
FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD: ${{ secrets.FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD }}
MATCH_GIT_BASIC_AUTHORIZATION: ${{ secrets.MATCH_GIT_BASIC_AUTHORIZATION }}
MATCH_GIT_URL: ${{ secrets.MATCH_GIT_URL }}
MATCH_KEYCHAIN_PASSWORD: ${{ secrets.MATCH_KEYCHAIN_PASSWORD }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
PILOT_APPLE_ID: ${{ secrets.PILOT_APPLE_ID }}
SPACESHIP_CONNECT_API_ISSUER_ID: ${{ secrets.SPACESHIP_CONNECT_API_ISSUER_ID }}
SPACESHIP_CONNECT_API_KEY_ID: ${{ secrets.SPACESHIP_CONNECT_API_KEY_ID }}
SPACESHIP_CONNECT_API_KEY_FILEPATH: ./fastlane/envfiles/AuthKey_KDAUTTM76R.p8
CI_RELEASE: true