Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1722 robotoff resend anonymous #2117

Merged

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented Jun 1, 2022

What

If the user decides to log in, resend the same answers again with credit for the current product, no product refreshing before login any more

Screenshot

simulator-screen-recording-iphone-13-2022-05-31-at-230922_RZWHIVDm.mp4

Fixes bug(s)

@cli1005 cli1005 requested a review from a team as a code owner June 1, 2022 09:22
@codecov-commenter
Copy link

Codecov Report

Merging #2117 (164055d) into develop (2ea0da3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2117      +/-   ##
==========================================
+ Coverage     8.86%   8.88%   +0.01%     
==========================================
  Files          161     178      +17     
  Lines         6623    8636    +2013     
==========================================
+ Hits           587     767     +180     
- Misses        6036    7869    +1833     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 12.64% <0.00%> (-19.67%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 64.10% <0.00%> (-18.88%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 19.60% <0.00%> (-14.61%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 26.47% <0.00%> (-4.96%) ⬇️
...s/smooth_app/lib/pages/onboarding/next_button.dart 0.00% <0.00%> (-4.00%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
packages/smooth_app/lib/main.dart 15.74% <0.00%> (-2.16%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df88561...164055d. Read the comment docs.

@teolemon
Copy link
Member

teolemon commented Jun 1, 2022

Do you have the barcode of the Saint-Nectaire @cli1005 ? I can't find it to check how the category was applied

@cli1005
Copy link
Contributor Author

cli1005 commented Jun 1, 2022

Do you have the barcode of the Saint-Nectaire @cli1005 ? I can't find it to check how the category was applied

2817896019485

@teolemon
Copy link
Member

teolemon commented Jun 1, 2022

mmmh… It was one hour ago, and didn't give you credit: https://world.openfoodfacts.org/product/2817896019485/st-nectaire-aop-laitier

@cli1005
Copy link
Contributor Author

cli1005 commented Jun 1, 2022

mmmh… It was one hour ago, and didn't give you credit: https://world.openfoodfacts.org/product/2817896019485/st-nectaire-aop-laitier

The answers are resent in the end of questionnaire (after login) with user id.
I don't know how it works on the server side, you mean if we send an answer with user id, we do not need to have the other votes? I am not sure about it ... since I tried with my account, we still need 3 votes (sent with user id) to get the question answered definitely (to have those scores )...

@g123k
Copy link
Collaborator

g123k commented Jun 1, 2022

True, I have to finish my implementation before doing this issue. So please take another one

@teolemon
Copy link
Member

teolemon commented Jun 1, 2022

? @g123k did you mean to comment on this issue ?

@cli1005
Copy link
Contributor Author

cli1005 commented Jun 2, 2022

or maybe this one #1724 ? :)

@teolemon teolemon requested review from g123k and M123-dev June 5, 2022 20:40
@teolemon
Copy link
Member

@alexgarel We still need 3 votes for logged in

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@M123-dev M123-dev merged commit 01c6a61 into openfoodfacts:develop Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Robotoff does not behave as expected during the transition from logged out to logged in
5 participants