-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #944 - added a category picker page to the temporary product button #1148
feat: #944 - added a category picker page to the temporary product button #1148
Conversation
…ry product button New files: * `category_cache.dart`: Cache where we download and store category data. * `category_picker_page.dart`: Category picker page. * `product_refresher.dart`: Refreshes a product on the BE then on the local database. Impacted files: * `new_product_page.dart`: now the temporary button opens the category picker page. * `nutrition_page_loaded.dart`: refactored using new class `ProductRefresher`.
Are the different icons voluntary @monsieurtanuki , compared to the initial implem for search refinement ? |
As far as I know the implementation you're referring to 1. is still a draft 2. is on the search page ("let's filter all results even more by categories") and not on the product page ("let me set a more appropriate category for this product"). |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monsieurtanuki I guess since it's dev mode, and unless @M123-dev has some feedback, that's good with me (with the possibility to fix later)
Thank you @teolemon for your review: of course UI and features can be fixed later. |
What
New files
category_cache.dart
: Cache where we download and store category data.category_picker_page.dart
: Category picker page.product_refresher.dart
: Refreshes a product on the BE then on the local database.Impacted files
new_product_page.dart
: now the temporary button opens the category picker page.nutrition_page_loaded.dart
: refactored using new classProductRefresher
.Several points pending
Screenshot
Fixes bug(s)
Part of
(please be as granular as possible)