-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add retry button in case of Internet Error #1105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @danagbemava!
Several remarks though:
- perhaps renaming your PR "feat: " instead of "[feat] " would be more git-effective - to be confirmed by @M123-dev
- while you're here, you could make
setBarcodeState
private (as_setBarcodeState
) - I believe you should create branches instead of coding directly on
develop
. But I'm not an expert ongit
. Really not. - The icing on the cake would be to check the network availability - I'm not even talking of callbacks when the connection is up again - like before suggesting a refresh to the end-user, check the network first. Not in this PR. We can see later if we need to spend time on this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @danagbemava, the code looks good.
To what @monsieurtanuki said, yes we follow the convention for naming feat: / fix: / ... so that they get picked up by a intigration which automatically creates the changelog (#962) , but that's just a minor detail.
Thanks for the feedback.
I had considered this, but I didn't envision this PR to touch a lot of files in my initial thought process, but I'll keep that in mind for future contributions.
I considered something similar, where I would check the network state and show an error |
Thanks @danagbemava I've just merged your pull request, it is now integrated to the develop branch 🥳 |
What
Video
telegram-cloud-document-4-5780477560336944279.mp4
Fixes bug(s)
Part of
(please be as granular as possible)