Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make all glass bottles recyclable by default #7945

Merged
merged 6 commits into from
Jan 6, 2023
Merged

feat: make all glass bottles recyclable by default #7945

merged 6 commits into from
Jan 6, 2023

Conversation

diivi
Copy link
Member

@diivi diivi commented Jan 4, 2023

What

All glass bottles should be recyclable by default.

Screenshot

image
image

Related issue(s) and discussion

@diivi diivi requested a review from a team as a code owner January 4, 2023 22:28
@github-actions github-actions bot added 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests labels Jan 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

alexgarel
alexgarel approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @stephanegigandet do you want to take a look ?

@stephanegigandet
Copy link
Contributor

LGTM. @stephanegigandet do you want to take a look ?

I did, let's merge :)

@stephanegigandet stephanegigandet merged commit 6062126 into openfoodfacts:main Jan 6, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@alexgarel alexgarel alexgarel approved these changes

Assignees

@diivi diivi

Labels
📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All glass bottles should be recyclable by default
3 participants
@diivi @stephanegigandet @alexgarel