Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Introduction to the Open Food Facts API #7444

Merged
merged 19 commits into from
Oct 13, 2022
Merged

docs: Introduction to the Open Food Facts API #7444

merged 19 commits into from
Oct 13, 2022

Conversation

Roxie-32
Copy link
Collaborator

@Roxie-32 Roxie-32 commented Oct 5, 2022 •
edited by teolemon
Loading

What

  • This is the first draft of the introduction to the OFF API.
  • It has a lot of corrections and comments on things to consider as we keep building the general docs. A lot of links to add but they are unavailable at the moment so those comments will help add them later on.

Part of

@Roxie-32 Roxie-32 requested a review from a team as a code owner October 5, 2022 07:23
@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label Oct 5, 2022
@aleene
Copy link
Contributor

aleene commented Oct 5, 2022

Looks good. Shall we convert this to a draft?

teolemon
teolemon reviewed Oct 5, 2022
View reviewed changes
docs/introduction/api.md Outdated Show resolved Hide resolved
@teolemon teolemon changed the title docs: Introduction to the OFF API docs: Introduction to the Open Food Facts API Oct 5, 2022
alexgarel
alexgarel reviewed Oct 7, 2022
View reviewed changes
docs/introduction/api.md Outdated Show resolved Hide resolved
alexgarel
alexgarel requested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions.

docs/introduction/api.md Outdated Show resolved Hide resolved
docs/introduction/api.md Outdated Show resolved Hide resolved
docs/introduction/api.md Show resolved Hide resolved
docs/introduction/api.md Outdated Show resolved Hide resolved
docs/introduction/api.md Outdated Show resolved Hide resolved
docs/introduction/api.md Outdated Show resolved Hide resolved
docs/introduction/api.md Outdated Show resolved Hide resolved
docs/introduction/api.md Show resolved Hide resolved
docs/introduction/api.md Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Oct 13, 2022
View reviewed changes
docs/introduction/api.md Outdated Show resolved Hide resolved
alexgarel
alexgarel approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Roxie-32 looks good to me !

I made a last suggestion that you can apply before merging.

@alexgarel
Copy link
Member

I made a suggestion for the cookie auth :-)

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Roxie-32 Roxie-32 merged commit 8572eb2 into main Oct 13, 2022
@Roxie-32 Roxie-32 deleted the docs-introduction branch October 13, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@alexgarel alexgarel alexgarel approved these changes

Assignees

@Roxie-32 Roxie-32

Labels
📚 Documentation Documentation issues improve the project for everyone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Roxie-32 @aleene @alexgarel @teolemon