Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add recycling for glass bottles #6620

Closed
wants to merge 2 commits into from
Closed

feat: add recycling for glass bottles #6620

wants to merge 2 commits into from

Conversation

LandonPattison
Copy link
Member

Description

added glass bottles as recyclable.
added "recycling" : "en:recycle", to t/expected_test_results/packaging/packaging_text_en_glass_bottle.json

Related issue(s) and discussion

@LandonPattison LandonPattison requested a review from a team as a code owner April 15, 2022 08:05
@LandonPattison LandonPattison changed the title add recycling(glass bottles) feat: add recycling for glass bottles Apr 15, 2022
@stephanegigandet stephanegigandet mentioned this pull request Apr 15, 2022
Merged
stephanegigandet
stephanegigandet requested changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this updates the test, but I don't see code to make the actual change, did you forget to commit the corresponding code changes?

@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@LandonPattison
Copy link
Member Author

@stephanegigandet I have tried adding this code if(($packaging_ref->{shape} eq "en:bottle") and ($packaging_ref->{material} eq "en:glass")){ %packaging_ref->{recycling} = "en:recycle" } into packaging.pm or into ecoscore.pm could not get this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet requested changes

Assignees
No one assigned
Labels
None yet
Projects
old prs
Status: No status
📦 Packaging improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All glass bottles should be recyclable by default
2 participants
@LandonPattison @stephanegigandet