Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW DESIGN : Leaflet map goes above content. #9118

Closed
Tracked by #7295
Valimp opened this issue Oct 6, 2023 · 8 comments · Fixed by #9602
Closed
Tracked by #7295

NEW DESIGN : Leaflet map goes above content. #9118

Valimp opened this issue Oct 6, 2023 · 8 comments · Fixed by #9602
Assignees
Labels
🐛 bug This is a bug, not a feature request. CSS good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. HTML JavaScript

Comments

@Valimp
Copy link
Collaborator

Valimp commented Oct 6, 2023

What

Leaflet map goes above content, it's weird when you scroll.
Capture d’écran 2023-10-06 à 09 40 58

Steps to reproduce the behavior

  1. Go to ah product with location
  2. Scroll
  3. See error

Expected behavior

Change z-index of leaflet map to match with the content.

Screenshot/Mockup/Before-After

Capture d’écran 2023-10-06 à 09 40 58

Part of

@Valimp Valimp added 🐛 bug This is a bug, not a feature request. good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. JavaScript HTML CSS labels Oct 6, 2023
@SarthakD15
Copy link

Hey @Valimp, I want to work on this issue can you please assign it to me?

@teolemon
Copy link
Member

teolemon commented Oct 7, 2023

@SarthakD15 assigned

@SarthakD15
Copy link

Thanks !

@shamun-khatri
Copy link
Contributor

Hey, @SarthakD15 are you stll working on this issue?

@alexgarel
Copy link
Member

@shamun-khatri I think you can take it :-)

@shamun-khatri
Copy link
Contributor

shamun-khatri commented Dec 26, 2023

Hey, @teolemon while setting up the project locally on Windows I am getting an error on "make dev" that is not mentioned in Guide and till now I have done:

1- Reinstalling docker.
2- Clean installation of docker by removing every single file associated with docker and then reinstall.
3- every time I redo the process I clone a fresh file by running the given command for cloning.

I am attaching an image of the error.
error 1
error 2

shamun-khatri added a commit to shamun-khatri/openfoodfacts-server that referenced this issue Dec 27, 2023
@shamun-khatri
Copy link
Contributor

Hi, I used Gitpod to set up the project. I tried to setup in Windows and Linux but it's not happening. Anyway, I opened the first pull request because I fixed this issue please review it.
Thanks.

@shamun-khatri
Copy link
Contributor

hi @alexgarel @teolemon please look forward to my pull request for this issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. CSS good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. HTML JavaScript
Projects
Development

Successfully merging a pull request may close this issue.

5 participants