Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW DESIGN: remaining issues #7295

Open
27 of 53 tasks
Tracked by #5513
alexgarel opened this issue Sep 5, 2022 · 8 comments
Open
27 of 53 tasks
Tracked by #5513

NEW DESIGN: remaining issues #7295

alexgarel opened this issue Sep 5, 2022 · 8 comments
Labels
CSS 🎨 Design good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Hacktoberfest JavaScript 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. P2 Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.

Comments

@alexgarel
Copy link
Member

alexgarel commented Sep 5, 2022

We are implementing a complete redesign of the OFF website based on the design of the new app. The new design is available on Figma here: https://www.figma.com/file/Qg9URUyrjHgYmnDHXRsTTB/New-website-design-(2022)-(Quentin)?node-id=169%3A4043

This issue tracks small problems still to be fixed in redesign2 branch.

The redesign is now live on https://world.openfoodfacts.org
(Before, The redesign2 branch is regularly deployed to the dev server: https://world.openfoodfacts.dev (login and password: off )

image

To contribute:

NICE TO HAVE

  1. Hacktoberfest Template::Toolkit ⏰ Stale 🎨 Design 🎨 New design
    jusfla
  2. vitamins 🎨 Design 🎨 New design 📖 Knowledge Panels
  3. 🎨 Design 🎨 New design 📖 Knowledge Panels 📦 Packaging
  4. CSS Hacktoberfest good first issue ⏰ Stale 🎨 Design 🎨 New design
  5. CSS good first issue ⏰ Stale 🎨 Design 🎨 New design
  6. 🎨 New design 🛣️ Road to scores
  7. 0 of 5
    CSS Dark mode 🎨 Design 🎨 New design
  8. CSS good first issue ✏️ Editing 🎨 Design 🎨 Needs design 🎨 New design 🐛 bug
    TCatinaud
  9. CSS good first issue personal search ⏰ Stale 🎨 New design 🐛 bug
    Valimp
  10. CSS good first issue product lists ⏰ Stale 🎨 New design 🐛 bug
    TCatinaud
  11. CSS HTML JavaScript good first issue 🐛 bug
    SarthakD15
  12. CSS good first issue ✏️ Editing 🎨 New design 🐛 bug
  13. CSS good first issue product history ⏰ Stale 🎨 New design
  14. CSS good first issue top navigation ⏰ Stale 🎨 New design
  15. CSS footer good first issue static content ⏰ Stale 🎨 New design
    Dev-Ashank
  16. CSS good first issue ⏰ Stale 🎨 Design 🎨 New design
    karthiknadar1204
  17. CSS JavaScript good first issue product lists ⏰ Stale 🎨 New design
  18. CSS JavaScript good first issue top navigation ⏰ Stale 🎨 New design
  19. Product Page good first issue inline edit ⏰ Stale 🎨 Mockup available 🎨 New design 🖼️ Images
  20. Product Page good first issue inline edit ⏰ Stale 🎨 New design 🥗 Ingredients
  21. good first issue homepage ⏰ Stale 🎨 New design

FIXED

  1. ⏰ Stale 🎁 donations 🎨 New design 🎯 P0
  2. CSS good first issue product history responsive ux ✏️ Editing 🎨 New design 🐛 bug
  3. CSS Signup Page Template::Toolkit Translations good first issue non tech ⏲️ 5 minute fix 🎨 New design 🐛 bug
  4. Admin tools CSS good first issue non tech 🎨 New design 🐛 bug 👥 Users
  5. CSS good first issue product lists 🎨 New design 🐛 bug
    Aman-Jamshed
  6. CSS good first issue top navigation 🎨 New design 🐛 bug
  7. good first issue product addition 🎨 New design
    stephanegigandet
  8. ⭐ top issue Admin tools good first issue ✏️ Editing 🎨 New design 🖼️ Images
  9. ⭐ 🐛 top bug ⭐ top issue regression 🎨 New design 🎯 P0 🐛 bug
  10. ⭐ 🐛 top bug 🎨 New design 🐛 bug
  11. CSS good first issue icons 🎨 New design
  12. CSS Hacktoberfest good first issue ✨ Feature 🎨 Design 🎨 New design
    yashfalke77
  13. stephanegigandet
  14. 🎨 Design 🎨 New design
    stephanegigandet
  15. good first issue
  16. icons 🎨 New design
  17. 🎨 Design 🎨 New design
  18. CSS Hacktoberfest good first issue 🎨 Design 🎨 New design
    stephanegigandet
  19. CSS good first issue product history 🎨 New design 🐛 bug

Part of

@alexgarel alexgarel changed the title New design: small remaining issues NEW DESIGN: small remaining issues Sep 5, 2022
@stephanegigandet stephanegigandet added the 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. label Sep 6, 2022
@stephanegigandet stephanegigandet changed the title NEW DESIGN: small remaining issues NEW DESIGN: remaining issues Sep 6, 2022
@stephanegigandet
Copy link
Contributor

Some information on which files to modify:

  • /scss/ contains all the SCSS files from which CSS files are generated. We use the Foundation 5.5.3 framework.
  • /templates contains HTML templates
  • /templates/web/common/site_layout.tt.html is the main template for all pages
  • /templates/web/pages contain templates for specific pages (e.g. product page, forms etc.)
  • on the product page, some content is generated from knowledge panels, the corresponding template is in /templates/panels/panel.tt.html

@aleene
Copy link
Contributor

aleene commented Oct 11, 2022

*I can add multiple tabs for the same language in the properties. Seems more like that the tab was doubled when adding a new language.

  • I can not edit the product name in the new language.

Screenshot 2022-10-11 at 15 03 12

@aleene
Copy link
Contributor

aleene commented Oct 11, 2022

When editing a new language there is no easy access the the FOP image. I have to scroll down to the ingredients, or switch back to the main language tab.

@aleene
Copy link
Contributor

aleene commented Oct 11, 2022

Adding a language for image or ingredients does not make appear a tab.
Screenshot 2022-10-11 at 15 06 43

@aleene
Copy link
Contributor

aleene commented Oct 11, 2022

  • Can not cancel an edit, nothing happens when I press the button.

@teolemon
Copy link
Member

teolemon commented Oct 2, 2023

@Valimp celle avec les issues du redesign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS 🎨 Design good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. Hacktoberfest JavaScript 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. P2 Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
Status: To discuss and validate
Status: To Discuss and Validate
Development

No branches or pull requests

5 participants