Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 990 - new knowledge panel "halfWidthOnMobile" field #992

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • New knowledge panel bool? halfWidthOnMobile field

Fixes bug(s)

Impacted files

  • api_get_product_test.dart: added a test for the new KP halfWidthOnMobile field
  • knowledge_panel.dart: added halfWidthOnMobile field
  • knowledge_panel.g.dart: wtf

Impacted files:
* `api_get_product_test.dart`: added a test for the new KP `halfWidthOnMobile` field
* `knowledge_panel.dart`: added `halfWidthOnMobile` field
* `knowledge_panel.g.dart`: wtf
Copy link
Contributor

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@monsieurtanuki monsieurtanuki merged commit 09d203a into openfoodfacts:master Nov 14, 2024
4 of 5 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review!

Don't hesitate to approve #985 now in order to start your dev in Smoothie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support "half_width_on_mobile" for KP
2 participants