feat: 986 - new Prices fields #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file: * `location_type.dart`: Type of the Location. Impacted files: * `api_prices_test.dart`: refactored with the additional fields * `location.dart`: added fields `locationType` and `websiteUrl` * `location.g.dart`: generated * `maybe_error.dart`: now we accept valid but unreadable responses * `open_prices_api_client.dart`: safer `createPrice` method; refactored with the additional fields * `openfoodfacts.dart`: added file `location_type.dart` * `price.dart`: added field `receiptQuantity` * `price.g.dart`: generated * `price_total_stats.dart`: added fields `locationTypeOsmCount`, `locationTypeOnlineCount`, `proofTypeGdprRequestCount` and `proofTypeShopImportCount` * `price_total_stats.g.dart`: generated * `proof.dart`: added fields `receiptPriceCount` and `receiptPriceTotal` * `proof.g.dart`: generated * `update_price_parameters.dart`: added field `receiptQuantity` * `update_proof_parameters.dart`: added fields `receiptPriceCount`, `receiptPriceTotal`, `locationOSMId` and `locationOSMType`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #987 +/- ##
==========================================
- Coverage 76.34% 75.85% -0.50%
==========================================
Files 239 251 +12
Lines 8494 9379 +885
==========================================
+ Hits 6485 7114 +629
- Misses 2009 2265 +256 ☔ View full report in Codecov by Sentry. |
teolemon
approved these changes
Oct 29, 2024
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
createPrice- now we don't care if we cannot fully read the server response body, as long as the status code has the expected value. In order to prevent trying to recreate over and over a Price when the response body evolves.Fixes bug(s)
Part of
Files
New file:
location_type.dart: Type of the Location.Impacted files:
api_prices_test.dart: refactored with the additional fieldslocation.dart: added fieldslocationTypeandwebsiteUrllocation.g.dart: generatedmaybe_error.dart: now we accept valid but unreadable responsesopen_prices_api_client.dart: safercreatePricemethod; refactored with the additional fieldsopenfoodfacts.dart: added filelocation_type.dartprice.dart: added fieldreceiptQuantityprice.g.dart: generatedprice_total_stats.dart: added fieldslocationTypeOsmCount,locationTypeOnlineCount,proofTypeGdprRequestCountandproofTypeShopImportCountprice_total_stats.g.dart: generatedproof.dart: added fieldsreceiptPriceCountandreceiptPriceTotalproof.g.dart: generatedupdate_price_parameters.dart: added fieldreceiptQuantityupdate_proof_parameters.dart: added fieldsreceiptPriceCount,receiptPriceTotal,locationOSMIdandlocationOSMType