Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag Migrations #577

Closed
wants to merge 1 commit into from
Closed

Conversation

pixeldrew
Copy link

Description

Adds cmd line argument to load flag, variants and segments from yaml files

Motivation and Context

I needed the ability to deploy flags as code, I paired these changes with a CI task that will upload a repository of yaml migration files that are written by developers. This allows us to migrate flags through environments with stable keys and to have the flags/changes peer reviewed.

How Has This Been Tested?

Tested using sqlite and mysql, on a osx environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pixeldrew pixeldrew force-pushed the feature-migrations branch 3 times, most recently from bb536ec to 08e5b71 Compare March 30, 2024 20:43
flag migrations as yaml
@pixeldrew
Copy link
Author

@nothing0012 can you take a look at this feature? Would like to not have to maintain my own image.

Copy link

github-actions bot commented Jun 9, 2024

Stale pull request message

@pixeldrew
Copy link
Author

Can we open this again? I've updated the branch to be in sync and tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant