Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove defaults for caching parameters #927

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: remove defaults for caching parameters #927

merged 1 commit into from
Jan 9, 2025

Conversation

miparnisari
Copy link
Member

Description

Remove flag defaults from the doc an point users to either config-schema.json, or openfga run --help.

References

https://cloud-native.slack.com/archives/C06G1NNH47N/p1736442619949489

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@miparnisari miparnisari requested a review from a team as a code owner January 9, 2025 17:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2025-01-09 17:47 UTC

@rhamzeh rhamzeh merged commit 9a03caa into main Jan 9, 2025
12 checks passed
@rhamzeh rhamzeh deleted the parameter-defaults branch January 9, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miparnisari @rhamzeh