Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added F# template #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added F# template #86

wants to merge 1 commit into from

Conversation

hayer
Copy link

@hayer hayer commented Jun 4, 2019

Added my F# template to the templates.json list, #64.

Signed-off-by: Peder Husom <[email protected]>
@derek derek bot added the new-contributor label Jun 4, 2019
@alexellis
Copy link
Member

Hi @hayer

Since you built your template we've upped the security requirements on the default OpenFaaS configuration.

You'll need to update your template to use a non-root user and ideally pull in the watchdog binary via a multi-stage build.

Please have a look at how we did it for the "csharp" template in the openfaas/templates repo

cc @rgee0 @burtonr to help if needed

@hayer
Copy link
Author

hayer commented Jun 4, 2019

@alexellis updated the Dockerfile now.

@alexellis
Copy link
Member

Please just do the following now for merge:

  • rebase
  • Add examples to your README.md on how to use the template with a sample or two

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed

@burtonr
Copy link
Contributor

burtonr commented Nov 10, 2019

Hello @hayer! I know it's been a little while, but would you be able to complete the final steps to getting this merged?

It'd be best to have a sample function in the readme file to demonstrate how to write a function using your template.

Also, there is now a conflict in the templates.json file that needs to be rebased and resolved before we can merge.

Let me know if you need any help, or have any questions!

@alexellis
Copy link
Member

Having a clear-up on GitHub issues / PRs over 1 month old. Let's revisit as necessary. Thank you for the PR.

@hayer
Copy link
Author

hayer commented Feb 7, 2020

Will take a look this weekend. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants