Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R/rstats templates #135

Closed
wants to merge 2 commits into from
Closed

Add R/rstats templates #135

wants to merge 2 commits into from

Conversation

psolymos
Copy link

@psolymos psolymos commented Jan 20, 2021

I created R/rstats templates using different HTTP frameworks and base images. I've decided to add the following 2 to the templates.json file of the store repository for the following reason:

  • rstats-minimal: vanilla R + classic watchdog on Alpine base image, should be suitable as the smallest build for text/JSON based functions not needing additional R functionality
  • rstats-base-plumber: R with plumber package installed + of-watchdog on Debian base image, this is the most versatile, plumber is mature with great community support and easy to add serializers/parsers through code annotation.

The https://github.com/analythium/openfaas-rstats-templates repository has other templates that might not be all suitable for mainstream consumption. The repo also has detailed documentation and an increasing number of examples.

R templates was discussed previously on Slack and offline, thanks for the great feedback.

I opened the related #114 request previously.

@derek
Copy link

derek bot commented Jan 20, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Jan 20, 2021
@psolymos
Copy link
Author

No-dco. Will try again.

@psolymos psolymos closed this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant