Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: additional tidying and use ctx propogation to enable docker build cancellation #971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucasRoesler
Copy link
Member

Copy the execute package into the project to add the require context passing. This can be pulled back later once we are happy with the implementation.

Streamline some of the watch and local-run code to use the native Context object instead of the Cancel object.

Use a WaitGroup to ensure that each run of the onChange is finished before starting the next invocation. This avoids a potential race-condition due to cmd object being a shared pointer and the context being cancelled and replaced.

Reduce the number of FAAS_DEBUG checks required for logging, by creating a shared logger package for this.

Motivation and Context

How Has This Been Tested?

I have manually tested this with the local-run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy the execute package into the project to add the require context
passing. This can be pulled back later once we are happy with the
implementation.

Streamline some of the watch and local-run code to use the native
Context object instead of the Cancel object.

Signed-off-by: Lucas Roesler <[email protected]>
@LucasRoesler LucasRoesler self-assigned this Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant