Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EWPP-5156: Update to ECL 5.0.0-alpha1. #1543

Open
wants to merge 10 commits into
base: 5.x
Choose a base branch
from
Open

EWPP-5156: Update to ECL 5.0.0-alpha1. #1543

wants to merge 10 commits into from

Conversation

22Alexandra
Copy link
Contributor

No description provided.

@sergepavle
Copy link
Member

The banner looks broken on /components page (in oe_theme and ewpp):
image

@sergepavle
Copy link
Member

sergepavle commented Jan 24, 2025 •
edited
Loading

Looks like Carousel has an issue on the ECL side if the empty copywrite value space is still visible:
image

@22Alexandra
Copy link
Contributor Author

The banner looks broken on /components page (in oe_theme and ewpp): image

This was caused by the combination of pattern preview values creating a "plain background" variant with an image which wouldn't happen with the paragraph, so I fixed the preview values.

@22Alexandra
Copy link
Contributor Author

Looks like Carousel has an issue on the ECL side if the empty copywrite value space is still visible: image

This happens when only one item of the carousel has the credit value provided and the others not, I'll open a ticket for the FRONT team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergepavle sergepavle sergepavle approved these changes

@intelektron intelektron intelektron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@22Alexandra @sergepavle @intelektron