Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "beta" label to libraries v2 content + item bank buttons #35690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Oct 22, 2024

Description

Adds a "beta" label to the new Libraries V2 components in legacy Studio.

This change affects Course Authors using legacy Studio to add blocks to units.

image

Supporting information

Relates to: openedx/frontend-app-authoring#1415
Private-ref: FAL-3907

Testing instructions

  1. Ensure meilisearch is enabled to enable Libraries V2 content.
  2. Disable these waffle flags to use legacy Studio's unit page:
    • contentstore.new_studio_mfe.use_new_course_outline_page
    • contentstore.new_studio_mfe.use_new_unit_page
  3. Create/edit a Unit
  4. Check that the "beta" label shows under the "Library Content" button.

Deadline

ASAP -- before Sumac cuts

Other information

  1. The "Itembank" XBlock is being added by Add "beta" label to Library Content and Problem Bank blockls frontend-app-authoring#1415 ; this will add the "beta" label to this block type too.
  2. Designs provided preferred a light green (#E7FEE7) background, but to avoid issues with custom themes, I decided to use built-in colors for background and text.

@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants