Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visual and progress score display enhancement #34860

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented May 27, 2024

Description

This pull request contains styling fixes and display problem score for Problem xblock.

  • [1] Add more space between problem description and options block.
  • [2] Center radio/checkbox button and answer text in options.
  • [3] Display float number in the points score label above the options block (display the floating point number after sending in the same format as when loading the block).

Related Pull Requests

PR to the quince branch: #34861
PR to the redwood branch: #34862

Screenshots before:

[1] image [2] image [3] before submit image [3] after submit image

Screenshots after:

[1] image [2] image [3] before submit image [3] after submit image

Steps to Reproduce:

  1. Enable new video editor and sharing by adding in /admin/waffle/flag/
  • new_core_editors.use_new_problem_editor
  1. In studio open unit -> add new component -> Problem -> Single / Multiple select
  2. Check problem displaying

@openedx-webhooks
Copy link

openedx-webhooks commented May 27, 2024

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211
Copy link

Hi @ihor-romaniuk - it looks like some checks didn't run on this. Are you able to try again?

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix/visual-and-logic-enhancement-for-problems branch from 96140d8 to a11b065 Compare August 20, 2024 15:58
@ihor-romaniuk
Copy link
Contributor Author

Hello @mphilbrick211. This Pull Request has been rebased on the master and ready for review.

@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Aug 20, 2024
@mphilbrick211
Copy link

Thanks, @ihor-romaniuk!

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix/visual-and-logic-enhancement-for-problems branch from a11b065 to 8562dd5 Compare September 3, 2024 15:39
@mphilbrick211
Copy link

Hi @openedx/wg-build-test-release-security-patchers! Are you able to help with this and its 2 backports?

@farhaanbukhsh
Copy link
Member

@mphilbrick211 I can help with this, also do we really need to backport this?

@farhaanbukhsh farhaanbukhsh self-requested a review November 13, 2024 07:27
@mphilbrick211
Copy link

@mphilbrick211 I can help with this, also do we really need to backport this?

@farhaanbukhsh - thanks! At this point I'm not sure about the backports, but can check.

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/fix/visual-and-logic-enhancement-for-problems branch from 8562dd5 to 3e388a7 Compare December 3, 2024 08:58
@mphilbrick211 mphilbrick211 removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Dec 10, 2024
@farhaanbukhsh
Copy link
Member

Hey @ihor-romaniuk I am trying to test this and I am still not getting any UI changes that are suggested in the PR, can you have a look at these please? :)

@farhaanbukhsh
Copy link
Member

@ihor-romaniuk any updates here?

@mphilbrick211 if @ihor-romaniuk is not ready to pursue these changes then we should close this and other backport PRs.

@ihor-romaniuk
Copy link
Contributor Author

Hello @farhaanbukhsh,
Thank you for your comment. It looks like I lost some changes during refactoring.
I'll check it and add all required changes.

@mphilbrick211
Copy link

@farhaanbukhsh I think it's OK to close this and the backports for the moments. @ihor-romaniuk - if you want to pursue in the future, we can reopen.

Thank you both!

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Jan 14, 2025
@farhaanbukhsh
Copy link
Member

@mphilbrick211 Thank you

@ihor-romaniuk Feel free to open a new PR, we can start with making a PR to master and then once it gets merged we can backport those changes if required, this will save a lot of effort from your side and from maintainers side to review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants