-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: swap bootstrap for paragon sass #27771
feat: swap bootstrap for paragon sass #27771
Conversation
Paragon core sass depends on the tilda import shortcut
studio-main increases in size by 130kb studio-main-v1 increases in size by 400kb
lms-discussion-bootstrap.css increases in size by 140kb lms-main.css increases in size by 180kb
lms-course.css is 200kb larger lms-footer-edx.css is 700kb larger lms-main-v1 is 1mb larger
lightest -> $light-300 gray-dark -> $gray-700; purchase -> $success
its unneeded and caused weird layout
fill in inverse and pink colors immediately after any import of paragon sass. Helps to avoid needing to redefine color concepts in this PR. We assume $inverse is $white by default
jenkins run quality |
1 similar comment
jenkins run quality |
Your PR has finished running tests. There were no failures. |
Thanks for the pull request, @abutterworth! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the |
This work has stalled. See #31616. |
@abutterworth Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Swap Bootstrap SASS for Paragon SASS throughout studio and lms.
Builds off https://github.com/edx/edx-platform/pull/27751 and depends on https://github.com/edx/edx-themes/pull/737.
~
in imports to meannode_modules/
that Paragon relies uponKey file sizes: