Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: functions to handle umbrella upgrade #81

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

r1jt
Copy link
Collaborator

@r1jt r1jt commented Oct 15, 2024

Below functions are needed to handle
umbrella chart based upgrade

  1. HelmGetValues to Get values for a release from helm command
  2. SaveHelmValuesto Save values for a release from helm command to a yaml file
  3. HelmUpgradeChartfromYaml to Upgrade a chart from a yaml file using helm command

@r1jt r1jt force-pushed the upgrade-umbrella branch 2 times, most recently from 60a6920 to 683ed19 Compare October 24, 2024 08:15
Below functions are needed to handle
umbrella chart based upgrade
1. HelmGetValues to Get values for a release from helm command
2. SaveHelmValuesto Save values for a release from helm command to a yaml file
3. HelmUpgradeChartfromYaml to Upgrade a chart from a yaml file using helm command

Signed-off-by: Ranjith M P <[email protected]>
@r1jt r1jt changed the title Upgrade umbrella functions to handle umbrella upgrade Oct 24, 2024
@r1jt r1jt changed the title functions to handle umbrella upgrade fix: functions to handle umbrella upgrade Oct 24, 2024
@r1jt r1jt marked this pull request as ready for review October 24, 2024 08:21
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Copy link
Collaborator

@blaisedias blaisedias Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to change as well?

err := UpgradeHelmChart(e2e_config.GetConfig().Product.MongoHelmRepo, mb.namespace, app.Mongo.ReleaseName, mb.values)

Signed-off-by: Ranjith M P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants