-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: functions to handle umbrella upgrade #81
Open
r1jt
wants to merge
8
commits into
develop
Choose a base branch
from
upgrade-umbrella
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r1jt
force-pushed
the
upgrade-umbrella
branch
2 times, most recently
from
October 24, 2024 08:15
60a6920
to
683ed19
Compare
Below functions are needed to handle umbrella chart based upgrade 1. HelmGetValues to Get values for a release from helm command 2. SaveHelmValuesto Save values for a release from helm command to a yaml file 3. HelmUpgradeChartfromYaml to Upgrade a chart from a yaml file using helm command Signed-off-by: Ranjith M P <[email protected]>
r1jt
force-pushed
the
upgrade-umbrella
branch
from
October 24, 2024 08:20
683ed19
to
97631d3
Compare
r1jt
changed the title
functions to handle umbrella upgrade
fix: functions to handle umbrella upgrade
Oct 24, 2024
w3aman
approved these changes
Oct 24, 2024
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
Signed-off-by: Ranjith M P <[email protected]>
blaisedias
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need to change as well?
Line 251 in 869f8f8
err := UpgradeHelmChart(e2e_config.GetConfig().Product.MongoHelmRepo, mb.namespace, app.Mongo.ReleaseName, mb.values) |
Signed-off-by: Ranjith M P <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below functions are needed to handle
umbrella chart based upgrade