-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a test to enable and test rdma connect #1759
base: develop
Are you sure you want to change the base?
Conversation
dsharma-dc
commented
Oct 23, 2024
- Added a simple test to create and publish a nexus. Connect it over rdma.
- The connect API is modified to take transport parameter.
- The test automatically detects a suitable interface to create a soft-RDMA device, creates it and deletes it at the end of the test.
fde28b2
to
e6fd96c
Compare
The changes for composer dependencies are here: openebs/mayastor-dependencies#96 |
io-engine-tests/src/lib.rs
Outdated
// todo: More dynamic checks for module may be needed depending on platform. | ||
// Assume linux-modules-extra-$(uname -r) is installed. | ||
let _ = run_command_args( | ||
"modprobe", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather not do this and have this be a pre-requisites, just like nvme-*.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think this can be removed from here, I've added installation in bash script for cargo test anyway.
io-engine-tests/src/lib.rs
Outdated
iface.to_string() | ||
} | ||
|
||
pub fn delete_rdma_rxe_device() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should update cleanup script to clean these up in case of a crash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should update cleanup script to clean these up in case of a crash
deleting from cleanup script too now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not uninstalling the module though.
Signed-off-by: Diwakar Sharma <[email protected]>
e6fd96c
to
5c64d04
Compare