Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a test to enable and test rdma connect #1759

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dsharma-dc
Copy link
Contributor

  • Added a simple test to create and publish a nexus. Connect it over rdma.
  • The connect API is modified to take transport parameter.
  • The test automatically detects a suitable interface to create a soft-RDMA device, creates it and deletes it at the end of the test.

@dsharma-dc
Copy link
Contributor Author

The changes for composer dependencies are here: openebs/mayastor-dependencies#96

// todo: More dynamic checks for module may be needed depending on platform.
// Assume linux-modules-extra-$(uname -r) is installed.
let _ = run_command_args(
"modprobe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not do this and have this be a pre-requisites, just like nvme-*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this can be removed from here, I've added installation in bash script for cargo test anyway.

io-engine-tests/src/lib.rs Outdated Show resolved Hide resolved
io-engine/tests/nvmf.rs Outdated Show resolved Hide resolved
iface.to_string()
}

pub fn delete_rdma_rxe_device() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should update cleanup script to clean these up in case of a crash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should update cleanup script to clean these up in case of a crash

deleting from cleanup script too now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not uninstalling the module though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants