fix(plugin/block-devices): don't panic on unmanaged pools #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiago Castro <[email protected]>
When fetching the block-devices, don't panic if the pool spec is missing, that is, if the pool is unmanaged. (this can happen when troubleshooting and we remove pool from control plane). Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait and
dsharma-dc
Abhinandan-Purkait
approved these changes
Jan 10, 2025
Comment on lines
+426
to
+429
| " {id} {disks} {managed} {node} {status} {capacity} {allocated} {available} {committed} \n", | ||
| id = pool_state.id, | ||
| node = pool_state.node, | ||
| status = pool_state.status.to_string(), |
There was a problem hiding this comment.
Yeah agreed this is not a good way anymore now that the plugin has become more complex. The earlier intention was just to validate the stdout, tabular output, when the plugin was in initial stages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, the current plugin output tests are not running it seems as they otherwise fail when ran manually (at least the pool).
I fixed the pool test, but I don't think these are maintainable the way they are written. I'd rather smart parse the human output into json and then compare json with expected output.
Also we are calling rest directly, and thus we're not testing the actual calling of rest itself, we're just testing the human output formatting.