Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci enhancements #204

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Ci enhancements #204

wants to merge 12 commits into from

Conversation

pchandra19
Copy link

CI-enhancements

Abhinandan-Purkait
Abhinandan-Purkait approved these changes Oct 22, 2024
View reviewed changes
.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
niladrih
niladrih reviewed Oct 23, 2024
View reviewed changes
.github/workflows/pull_request.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Abhinandan-Purkait
Abhinandan-Purkait reviewed Oct 24, 2024
View reviewed changes
ct.yaml Outdated Show resolved Hide resolved
Abhinandan-Purkait
Abhinandan-Purkait reviewed Oct 24, 2024
View reviewed changes
nix/sources.nix Outdated Show resolved Hide resolved
Abhinandan-Purkait
Abhinandan-Purkait reviewed Oct 24, 2024
View reviewed changes
shell.nix Outdated Show resolved Hide resolved
@Abhinandan-Purkait
Copy link
Member

You would need to add the scripts and also need to fix the code coverage bit as well.

@pchandra19
fix: added scripts for charts
8be5764 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: scripts permissions
e8c2ec7 
Signed-off-by: Prateek Chandra <[email protected]>
Abhinandan-Purkait
Abhinandan-Purkait requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the chart version, the CI is still failing.

scripts/update-chart-version.sh Outdated Show resolved Hide resolved
@pchandra19
fix: chart version and code cov
66f8e10 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: test make file target
3dfd9d2 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: added missed step
ef01228 
Signed-off-by: Prateek Chandra <[email protected]>
@pchandra19
fix: missin namespace
e00db45 
Signed-off-by: Prateek Chandra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niladrih niladrih niladrih left review comments

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait requested changes

@tiagolobocastro tiagolobocastro Awaiting requested review from tiagolobocastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchandra19 @Abhinandan-Purkait @niladrih