Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix another case of the profile API returns prematurely #353

Merged

Conversation

kaituo
Copy link
Member

@kaituo kaituo commented Dec 30, 2020

Issue #, if available:
#339

Description of changes:

Testing done:

  1. Manually verified the issue has been fixed.
  2. Reproduced the issue using an unit test and verified fix using the test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing done:
1. Manually verified the issue has been fixed.
2. Reproduced the issue using an unit test and verified fix using the test.
@kaituo kaituo added the bug Something isn't working label Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #353 (aa842e6) into master (7df38a1) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #353      +/-   ##
============================================
+ Coverage     76.51%   76.63%   +0.11%     
- Complexity     2241     2245       +4     
============================================
  Files           209      209              
  Lines         10174    10173       -1     
  Branches        906      905       -1     
============================================
+ Hits           7785     7796      +11     
+ Misses         1975     1966       -9     
+ Partials        414      411       -3     
Flag Coverage Δ Complexity Δ
plugin 76.43% <100.00%> (+0.12%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...elasticsearch/ad/AnomalyDetectorProfileRunner.java 77.20% <100.00%> (ø) 61.00 <0.00> (ø)
...rch/ad/transport/AnomalyResultTransportAction.java 80.78% <0.00%> (-0.05%) 77.00% <0.00%> (ø%)
...stroforelasticsearch/ad/model/DetectorProfile.java 32.08% <0.00%> (+1.60%) 16.00% <0.00%> (+2.00%)
...asticsearch/ad/cluster/ADClusterEventListener.java 94.00% <0.00%> (+2.00%) 15.00% <0.00%> (+1.00%)
...pendistroforelasticsearch/ad/NodeStateManager.java 73.52% <0.00%> (+3.92%) 30.00% <0.00%> (+1.00%)
...mazon/opendistroforelasticsearch/ad/NodeState.java 97.77% <0.00%> (+4.44%) 15.00% <0.00%> (+1.00%)
...pendistroforelasticsearch/ad/cluster/HashRing.java 84.21% <0.00%> (+5.26%) 11.00% <0.00%> (+1.00%)

@kaituo kaituo merged commit 21418a4 into opendistro-for-elasticsearch:master Dec 31, 2020
ylwu-amzn pushed a commit that referenced this pull request Feb 24, 2021
Testing done:
1. Manually verified the issue has been fixed.
2. Reproduced the issue using an unit test and verified fix using the test.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants