Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
If you pass in a legacy
GeoBox
todc.load()
you eventually get an error from deep in the loading codeThis is the 1.9 equivalent of @robbibt 's #1551 PR to 1.8.
Proposed changes
Check for legacy
datacube.utils.geometry.GeoBox
objects in thedatacube.Datacube
API before calling loading code and convert toodc.geo.geobox.GeoBox
.Unit test
do class check without importing the deprecated legacy class to avoid deprecation warnings.
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes