Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "like=<geobox>" in virtual products #1497

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

uchchwhash
Copy link
Member

@uchchwhash uchchwhash commented Sep 21, 2023

Reason for this pull request

This is to address Issue #1276. Sincere apologies for not doing this earlier.

Proposed changes


📚 Documentation preview 📚: https://datacube-core--1497.org.readthedocs.build/en/1497/

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f45ba8c) 91.79% compared to head (29bd819) 91.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1497      +/-   ##
===========================================
- Coverage    91.79%   91.78%   -0.01%     
===========================================
  Files          132      132              
  Lines        14537    14539       +2     
===========================================
+ Hits         13344    13345       +1     
- Misses        1193     1194       +1     
Files Coverage Δ
datacube/virtual/impl.py 84.29% <66.66%> (-0.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uchchwhash uchchwhash merged commit 1ac445c into develop Oct 6, 2023
25 checks passed
@uchchwhash uchchwhash deleted the support-like-geobox branch October 6, 2023 02:33
@SpacemanPaul SpacemanPaul mentioned this pull request Oct 24, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue loading virtual product using like=ds.geobox
2 participants