Fix misconfigured alerts between Kibana ndjson & Elastalert #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikukissa
commented
Oct 7, 2024
| @@ -18,11 +18,100 @@ on: | |||
| description: 'PR number to process' | |||
There was a problem hiding this comment.
This is just an update to the auto-pr pipeline. Helps me now put this to 1.5.2 and 1.6.0
rikukissa
commented
Oct 7, 2024
| @@ -0,0 +1,54 @@ | |||
| import { readdirSync, readFileSync } from 'fs' | |||
There was a problem hiding this comment.
This now ensures the ndjson and the rule yaml files are always in sync
euanmillar
approved these changes
Oct 7, 2024
rikukissa
added a commit
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Riku Rouvila <[email protected]>
rikukissa
added a commit
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Riku Rouvila <[email protected]>
rikukissa
added a commit
that referenced
this pull request
Oct 7, 2024
Co-authored-by: Riku Rouvila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.