feat: ask for COUNTRY in setup environment #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@rikukissa It would still need to be manually updated from some files when forking country-config. |
naftis
commented
Sep 19, 2024
rikukissa
approved these changes
Sep 19, 2024
Siyasanga
pushed a commit
that referenced
this pull request
Oct 16, 2024
* feat: ask for COUNTRY in setup environment * feat: update country config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The country value is defaulted to FAR in core, but it changes per every environment so it shouldn't be defaulted in production. The environment validation caught this issue. Updated to ask for it in the setup environment script.