Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ui issues with Action Menu #8163

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix ui issues with Action Menu #8163

wants to merge 2 commits into from

Conversation

jpye-finch
Copy link
Collaborator

Fixes ui issues in Action menu

  • icon sizes
  • dropdown styling
  • replaces deprecated ResponsiveModel with Dialog
  • replaces deprecated PrimaryButton etc with Button
  • adds icon right positioning option

Copy link

github-actions bot commented Dec 5, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@@ -118,9 +115,10 @@ export const ActionMenu: React.FC<{
<>
<DropdownMenu id="action">
<DropdownMenu.Trigger>
<PrimaryButton icon={() => <CaretDown />}>
<Button type="primary" size="medium" iconPosition="right">
Copy link
Collaborator

@Zangetsu101 Zangetsu101 Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpye-finch The Button component shouldn't really concern itself where the icon is being positioned. I suggest trying to use flex to achieve the same from the calling end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants