Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch on mount #8139

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: fetch on mount #8139

wants to merge 4 commits into from

Conversation

tahmidrahman-dsi
Copy link
Collaborator

@tahmidrahman-dsi tahmidrahman-dsi commented Dec 3, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

naftis
naftis approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@naftis naftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the design looks good. Bevolv can continue on this work and if the design needs changes - we can assign them to do it. You merge IMO, do any cleanups if you need. 👍 A comment could be good as in how to use this field.

@tahmidrahman-dsi tahmidrahman-dsi changed the title feat(wip): fetch on mount feat: fetch on mount Dec 4, 2024
@tahmidrahman-dsi tahmidrahman-dsi added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 4, 2024
@tahmidrahman-dsi tahmidrahman-dsi marked this pull request as ready for review December 5, 2024 06:39
naftis
naftis reviewed Dec 10, 2024
View reviewed changes
packages/client/src/forms/index.ts
Comment on lines +734 to +737
callback: {
trigger: string
params: Record<string, string>
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to comment/document here(/where?) on what these refer to exactly with examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

Assignees
No one assigned
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 🚧 work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahmidrahman-dsi @naftis