Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour refactored to use Alta's #8110

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Colour refactored to use Alta's #8110

wants to merge 12 commits into from

Conversation

jpye-finch
Copy link
Collaborator

@jpye-finch jpye-finch commented Nov 29, 2024

Apply Alta's colour tweaks.

  • Updates Primary to OpenCRVS primary blue
  • Replaces darken and lighten colours to hardcoded - to ensure accessbility
  • Updates Pill colours
  • Updates colour story to simplify and show primary and secondary colours

@jpye-finch jpye-finch changed the title applies alta's colour tweaks Colour refactored to use Alta's Nov 29, 2024
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis
Copy link
Collaborator

naftis commented Dec 2, 2024

I think you can

cd packages/components
yarn remove polished

if we're not using it anymore

Comment on lines +62 to +73
// DEPRECTATED
blue: '#4A8AD7',
blueDark: '#4079BD',
blueDarker: '#3668A3',
blueLight: '#72A3E0',
blueLighter: '#A0C3EB',
secondary: '#4A8AD7',
tertiary: '#CCCCCC',
subheaderCopyBirth: '#007A5E',
subheaderCopyDeath: '#4B5EAA',
subheaderCopyMarriage: '#E4BC0C',
backgroundPrimary: '#36304E',
Copy link
Collaborator

@naftis naftis Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a plan or a ticket to remove these altogether later, or could they be removed now? We have a tendency not to clean up deprecated items so trying to push it going forwards.

Otherwise the pull request looks good to merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants