Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want to select a template to issue a certified copy with #7813

Open
wants to merge 63 commits into
base: develop
Choose a base branch
from
Open

As a user I want to select a template to issue a certified copy with #7813

wants to merge 63 commits into from
+2,082 −853

Conversation

tareq89
Copy link
Collaborator

@tareq89 tareq89 commented Oct 22, 2024 •
edited
Loading

@tareq89 tareq89 added this to the v1.7.0 milestone Oct 22, 2024
@tareq89 tareq89 self-assigned this Oct 22, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@tareq89 tareq89 force-pushed the ocrvs-7584 branch 2 times, most recently from 184ba01 to f814ace Compare October 22, 2024 13:04
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7584.opencrvs.dev

@tareq89 tareq89 force-pushed the ocrvs-7584 branch 2 times, most recently from bdc01ca to e21b0ea Compare October 29, 2024 13:32
@rikukissa
Copy link
Member

rikukissa commented Oct 31, 2024 •
edited
Loading

Seems the dropdown and the radio buttons in a different order to how the design is:

image

Design
image

rikukissa
rikukissa reviewed Oct 31, 2024
View reviewed changes
packages/client/src/declarations/index.ts Outdated Show resolved Hide resolved
packages/client/src/declarations/selectors.ts Outdated Show resolved Hide resolved
packages/client/src/views/PrintCertificate/collectorForm/CollectorForm.tsx Outdated Show resolved Hide resolved
packages/workflow/src/documents.ts Show resolved Hide resolved
packages/commons/src/fhir/extension.ts Show resolved Hide resolved
.../migration/src/migrations/hearth/20241029171702-add-certificateTemplateId-to-missing-docs.ts Outdated Show resolved Hide resolved
.../migration/src/migrations/hearth/20241029171702-add-certificateTemplateId-to-missing-docs.ts Show resolved Hide resolved
packages/client/src/views/RecordAudit/ActionDetailsModal.tsx Show resolved Hide resolved
@tareq89
Copy link
Collaborator Author

tareq89 commented Oct 31, 2024

Seems the dropdown and the radio buttons in a different order to how the design is:

image

Design image

I did not know such design existed. Any figma link of this design was not mentioned anywhere. Anyway, I have adjusted the code as per the design.

rikukissa
rikukissa approved these changes Nov 5, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
packages/client/src/declarations/index.ts Outdated Show resolved Hide resolved
@rikukissa rikukissa self-requested a review November 5, 2024 11:32
@euanmillar euanmillar mentioned this pull request Dec 10, 2024
Open
6 tasks
@tareq89 tareq89 deployed to ocrvs-7584 December 25, 2024 07:06 — with GitHub Actions Active
@tareq89 tareq89 enabled auto-merge (squash) December 25, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikukissa rikukissa rikukissa approved these changes

@Zangetsu101 Zangetsu101 Awaiting requested review from Zangetsu101

@Nil20 Nil20 Awaiting requested review from Nil20

Assignees

@tareq89 tareq89

Labels
In QA 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
2025 Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@tareq89 @ocrvs-bot @rikukissa @Zangetsu101 @naftis @tahmidrahman-dsi