Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid failing when lgetxattr has no data to give #526

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

hallyn
Copy link
Contributor

@hallyn hallyn commented Jan 22, 2024

No description provided.

@hallyn
Copy link
Contributor Author

hallyn commented Jan 22, 2024

See project-stacker/stacker#586

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9da0fd4) 73.48% compared to head (ad8ce08) 46.41%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #526       +/-   ##
===========================================
- Coverage   73.48%   46.41%   -27.08%     
===========================================
  Files          60       60               
  Lines        4888     4891        +3     
===========================================
- Hits         3592     2270     -1322     
- Misses        937     2353     +1416     
+ Partials      359      268       -91     
Files Coverage Δ
oci/layer/tar_generate.go 42.76% <0.00%> (-27.71%) ⬇️

... and 32 files with indirect coverage changes

@hallyn hallyn force-pushed the 2024-01-22/fix-empty-lgetxattr branch from 86fdc56 to 2c5e9b2 Compare January 22, 2024 20:35
@tych0
Copy link
Member

tych0 commented Jan 24, 2024

if you rebase hopefully CI will pass.

@hallyn hallyn force-pushed the 2024-01-22/fix-empty-lgetxattr branch from 2c5e9b2 to ad8ce08 Compare January 24, 2024 00:39
@hallyn
Copy link
Contributor Author

hallyn commented Jan 24, 2024

Thanks. "here goes"

@tych0 tych0 merged commit 909d140 into opencontainers:main Jan 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants