ci: avoid go install for github.com/opencontainers/runtime-tool #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 73.53% 73.46% -0.07%
==========================================
Files 60 60
Lines 4881 4881
==========================================
- Hits 3589 3586 -3
- Misses 933 935 +2
- Partials 359 360 +1 |
cyphar
force-pushed
the
ci-runtime-validate
branch
2 times, most recently
from
246e4c2 to
e19a963
Compare
All released versions of runtime-tool are not using go.mod, meaning that we end up pulling the latest version of their dependencies when using "go install". In particular, the runtime-spec update causes validation errors in our CI because we are still producing runtime-spec 1.0.2 config.jsons and runtime-tool doesn't support validating older versions. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
ci-runtime-validate
branch
from
e19a963 to
7cde0a2
Compare
|
LGTM, merging to fix CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All released versions of runtime-tool are not using go.mod, meaning that we end up pulling the latest version of their dependencies when using "go install". In particular, the runtime-spec update causes validation errors in our CI because we are still producing runtime-spec 1.0.2 config.jsons and runtime-tool doesn't support validating older versions.
Signed-off-by: Aleksa Sarai [email protected]