Support Map() API for ygnmi.SetBatch operations. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug when an empty/nil map is configured using the Map() API to be consistent with when using the non-Map API. After this PR is merged, we can simplify an existing FP test: https://github.com/openconfig/featureprofiles/pull/2472/files
Pull Request Test Coverage Report for Build 7390460599
💛 - Coveralls |
DanG100
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use this to simplify an existing FP test like so: https://github.com/openconfig/featureprofiles/pull/2472/files
With this PR merged, the Map() API for lists is supported for all existing ygnmi query APIs.
Also fix a bug when an empty/nil map is configured using the Map() API to be consistent with when using the non-Map API.